make "follow system" default for dark theme#5136
Merged
Merged
Conversation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
AndyScherzinger
approved these changes
Jan 9, 2020
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12195-IT |
Collaborator
|
Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12199-Screenshot |
Collaborator
|
Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12207-Screenshot |
Collaborator
|
Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12212-Screenshot |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12219.apk |
Collaborator
Codacy340Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #5136 +/- ##
============================================
+ Coverage 17.62% 17.69% +0.06%
Complexity 3 3
============================================
Files 392 392
Lines 33116 33120 +4
Branches 4651 4653 +2
============================================
+ Hits 5837 5860 +23
+ Misses 26320 26303 -17
+ Partials 959 957 -2
|
tobiasKaminsky
added a commit
that referenced
this pull request
Jan 12, 2020
ec515d0 [tx-robot] updated from transifex 422a61d Merge pull request #5136 from nextcloud/systemDefault 6e96e99 Merge pull request #5130 from nextcloud/createRichWorkspace b7a7772 Merge pull request #5122 from nextcloud/firstRun 603825e update screenshot c4d5e41 Merge pull request #5143 from nextcloud/background c6d89ed only allow rich workspace creation on >= Lollipop 87dae2e show first run again 9125285 manually increasing lint due to "autoMirrored" warning 4c10cf5 launcher: correct folder position according to AS 51fdf94 [tx-robot] updated from transifex e0b77f9 daily dev 20200110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5123
Signed-off-by: tobiasKaminsky tobias@kaminsky.me